Page 10 of 21

Re: Announcing GoReviewPartner - v0.9 (supporting AQ)

Posted: Sun Dec 17, 2017 7:39 pm
by pnprog
Hi!
johnsmith wrote:Is there a way to have a move marked on the graph? So we can quickly know where we are currently in the game?
Bring your mouse over the graph and if will display the move number and % below the graph. One click brings you to that position on the analysis panel. Is that what you need?

Re: Announcing GoReviewPartner - v0.9 (supporting AQ)

Posted: Mon Dec 18, 2017 2:44 am
by johnsmith
pnprog wrote:Hi!
johnsmith wrote:Is there a way to have a move marked on the graph? So we can quickly know where we are currently in the game?
Bring your mouse over the graph and if will display the move number and % below the graph. One click brings you to that position on the analysis panel. Is that what you need?
When I'm (for example) on move 42 in the game window, is it possible to have (for example) yellow highlighted bar in graph window on move 42?

Re: Announcing GoReviewPartner - v0.9 (supporting AQ)

Posted: Sat Dec 23, 2017 9:22 pm
by Caesura
Thank you for this great program!

I was just wondering if the following were possible:

-Can there be support for zen 7?
-I really like the comparison chart, which helps to identify my biggest mistakes which I can focus on. To this end, is it also possible to state the numerical difference in value between my move and Leela's move (reviews by rosystein seem to do something similar (https://rosystein.com/))? Right now, I calculate this information manually by going one move before, and calculating the difference based on the figures provided in the comments to the right goban.

By the way, are there any recommendations on how much time we should give Leela to consider each move, in order to say, have it reviewed at the strength of tygem 9d? I am using the CPU-only version, with intel i5-6200U CPU @ 2.30GHZ.

Many thanks once again!

Re: Announcing GoReviewPartner - v0.9 (supporting AQ)

Posted: Fri Dec 29, 2017 5:44 am
by pnprog
johnsmith wrote:
pnprog wrote:Hi!
johnsmith wrote:Is there a way to have a move marked on the graph? So we can quickly know where we are currently in the game?
Bring your mouse over the graph and if will display the move number and % below the graph. One click brings you to that position on the analysis panel. Is that what you need?
When I'm (for example) on move 42 in the game window, is it possible to have (for example) yellow highlighted bar in graph window on move 42?
Should be possible, I will look into it for next version.
Caesura wrote:Can there be support for zen 7?
For this, I need Zen to work as GTP version. As far as I now, Zen does not provide that feature. (otherwise, there would be plenty of Zen bots available on OGS/KGS... and nobody would buy their software).
Caesura wrote:I really like the comparison chart, which helps to identify my biggest mistakes which I can focus on. To this end, is it also possible to state the numerical difference in value between my move and Leela's move (reviews by rosystein seem to do something similar (https://rosystein.com/))? Right now, I calculate this information manually by going one move before, and calculating the difference based on the figures provided in the comments to the right goban.
Currently, the red bar (or green bar) indicates that difference:
GRP documentation wrote:By comparing the win rate at one move (when the bot best move would be played) with the win rate of the following move (the case when the actual game move was played), one can draw a comparison chart for each color.
I think this is the same quantity that your are calculating. The exact value appears on the graph when you bring your mouse pointer above the red (or green) bar:
example_graph.png
example_graph.png (27.6 KiB) Viewed 17049 times
You can the indication below the graph: "The computer believes it's own move win rate would be 17.76pp higher." Here, 17.76pp means 17.76 percentage point. In this example, the game move win rate was 47.97%, and the computer own move win rate is 47.97% + 17.76pp = 65.73%

Is that what you need?

Regarding recommendation for thinking time, I don't know as well. You will get more information by asking on reddit /r/cbaduk

I am currently out of town, but I plan to release a new version of GRP with Leela Zero support. I read a few report of reddit indicating its strength is increasing quickly, and may reach dan level before February. This is quite exiting!

Re: Announcing GoReviewPartner - v0.9 (supporting AQ)

Posted: Sun Dec 31, 2017 1:41 pm
by johnsmith
pnprog wrote:I am currently out of town, but I plan to release a new version of GRP with Leela Zero support. I read a few report of reddit indicating its strength is increasing quickly, and may reach dan level before February. This is quite exiting!
I think it already is at dan level, beating 3d hirabot here and there. We have observed some josekis emerging from selfplay as well.

I'm really looking forward to LZ implementation in GRP!

Re: Announcing GoReviewPartner - v0.9 (supporting AQ)

Posted: Mon Jan 01, 2018 7:30 am
by Caesura
pnprog wrote: You can the indication below the graph: "The computer believes it's own move win rate would be 17.76pp higher." Here, 17.76pp means 17.76 percentage point. In this example, the game move win rate was 47.97%, and the computer own move win rate is 47.97% + 17.76pp = 65.73%

Is that what you need?
Thank you! That is exactly what i needed. Sorry, i simply did not notice the words below the graph before asking the question.

Re: Announcing GoReviewPartner - v0.9 (supporting AQ)

Posted: Sun Jan 07, 2018 7:36 pm
by pnprog
Caesura wrote:Sorry, i simply did not notice the words below the graph before asking the question.
No problem, I think I need to put more work into the documentation as well !

I just started adding support for Leela Zero this morning (I am currently waiting for an analysis to complete). This is pretty straightforward because it behaves much like Leela, just a bit less complex in fact (for instance, no book moves to deal with). I will start uploading files on github today for those of you who want to try without waiting for the "official" release.

Re: Announcing GoReviewPartner - v0.9 (supporting AQ)

Posted: Mon Jan 08, 2018 2:33 am
by pnprog
I just pushed the modifications for Leela Zero support on Github.

Then I used Leela Zero to review one of her self-play games and I must say I am amazed to see how far she has gone already. Particularly, I can see she has find out by herself several of our human josekis (GRP makes it easy to see her follow up for different variations of the same joseki).

One caveat is that at the moment, Leela Zero is providing informations for a lot of possible moves. Like 55 possible moves for the game first move... GRP labels the variation using alphabet letters, so when the number of variations exceeds 26...

Here are the different possible moves for the game last move:
move287.png
move287.png (107.43 KiB) Viewed 18757 times
As you can see, too much information make it very hard to understand anything. And it makes the RSGF file pretty heavy.

I think I will have to add an option to limit the number of variation on display, while leaving the variation inside the SGF file.

But still, I am really impressed by Leela Zero!

=== EDIT ===
My todo list before official v.10, let me know if you have ideas
  • Add option to limit the number of variation to record during analysis
  • Add option to limit the number of variation to display during review
  • Add an option to add the complete command line of the bot as a comment in the RSGF file (useful to track Leela Zero weights file version)
  • Try and implement a work around to allow Ray (and AQ?) to undo a move during manual play
  • I need to fix a bug that appears when running the analysis of the giant seki games
  • Highlight the game current move on the charts
  • [Maybe for v.11]Add basic foundation to add additional languages
  • [Maybe for v.11]See how to make better use of SGF private properties to reduce the size of the RSGF file
  • [Maybe for v.11]See what change are needed to have GRP run on both python 2 and python 3
Also, I have been thinking of a new feature for v.11, something like "Live analysis":
Basically, a training session would looks like this for me:
  • 1/ Play a game against Leela
  • 2/ Perform the analysis of the game immediately afterwards (so I have to take a break while waiting for the analysis)
  • 3/ Review the analysis
  • 4/ Repeat from 1/
Indeed, more and more player are practising against Leela or others bots now. Problem for me is that the review takes ages on my slow computer. So I am thinking of introducing a way to play against the bot, while at the same time, performing the analysis, somehow "in the background". Then at the end of the game, the analysis is immediately ready to start the review:
  • So when it's the bot to play, GRP gets the data at the same time the bot is playing
  • When it's the player to play, GRP ask the bot to perform the analysis for your move in the background
Such feature could be extended to be used during game recording. Let's say you serve as game recorder during a Go Congress, then you input the moves of both players inside GRP, while GRP is running a Leela analysis in the background. At the end of the game, you got the SGF file and the RSGF ready and can perform a quick review with both players. Of course, the current state of the analysis would be available at whatever time during the game for you to check ("tell me Leela, who is wining that game?").

Re: Announcing GoReviewPartner - v0.9 (supporting AQ)

Posted: Mon Jan 08, 2018 5:18 am
by johnsmith
pnprog wrote: *Add option to limit the number of variation to record during analysis.
*Highlight the game current move on the charts.
*Also, I have been thinking of a new feature for v.11, something like "Live analysis": performing the analysis, somehow "in the background". Then at the end of the game, the analysis is immediately ready to start the review.
These are my favorites so far.

Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer

Posted: Wed Jan 24, 2018 12:28 am
by pnprog
Hi everybody!

I had the opportunity to watch the AlphaGo documentary on Youtube, then subsequently had a strong motivational boost to work on GRP !

So here come version 0.10 ! The main change is that support for Leela Zero has been added.

From last time to do list:
  • Add option to limit the number of variation to record during analysis [Done]
  • Add option to limit the number of variation to display during review [Done]
  • Add an option to add the complete command line of the bot as a comment in the RSGF file (useful to track Leela Zero weights file version) [Done]
  • Try and implement a work around to allow Ray (and AQ?) to undo a move during manual play [Done] In fact, the latest AQ 2.1.1 (released yesterday) has an issue with undoing moves, so this work around came very handy
  • I need to fix a bug that appears when running the analysis of the giant seki games [Done] Another user came into the same bug by the way, so glad I fixed that
  • Highlight the game current move on the charts [Done]
  • [Maybe for v.11]Add basic foundation to add additional languages [Done] I also added the French translation to GRP *. I am looking for help to add additional translations, please let me know if you are interested.
  • [Maybe for v.11]See how to make better use of SGF private properties to reduce the size of the RSGF file [To be done]
  • [Maybe for v.11]See what change are needed to have GRP run on both python 2 and python 3 [Cancelled] When the time is right, I will totally move GRP to python 3

* that awkward moment when I realise I have not idea how to translate what I wrote in English into my native language...


I also receive a lot of feedback on GitHub, so here a few other modifications done for v.10:
  • Specifying a time per move is not mandatory any more for Leela and LZ. The setting can be left blank, and then Leela will decide by herself (or using the playout limit from the command line)
  • Added an option to stop the analysis if the bot proposes to resign
  • Bugs fixes (for chart display, fuzzy parameters, display on MacOS, resizing on higher screen resolution...)
  • Added automatic answer and self play possibility for the bots during review
  • Some more candy eyes change to the UI
  • Images (gobans and graphs) are now saved as PNG, not Postscript (it might not work on second monitor on some Windows 8.1, let me know)
  • Last stone played is now marked with a circle (not a delta)
Documentation has been updated. (Maybe you will need to refresh the page with F5)

For the download, as usual: For next version, I will implement the "Live analysis" I mentioned above. It should be a lot of work, but I will have time in February.

But then, starting from March, I expect to have much less free time for this project :(
Anyway, the next version might (finally) be the v1.0, because I don't see much new feature to add. Maybe v1.1, v1.2, v1.3 will be released only for new bot support, new translation available and bug fixes.

Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer

Posted: Wed Jan 24, 2018 8:11 am
by bernds
I've recently started using this and I have to say it's a very nice and useful tool.

Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer

Posted: Fri Jan 26, 2018 5:47 am
by johnsmith
Thanks! Great as always :)

Is there a way to put evaluations in "Open position" window? So when we analyze a move from current position we can have its evaluation.

Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer

Posted: Fri Jan 26, 2018 8:21 am
by pnprog
johnsmith wrote:Is there a way to put evaluations in "Open position" window? So when we analyze a move from current position we can have its evaluation.
I am planning to add a small analysis feature in the "Open position" windows, but only something simple to ask Leela (or AQ/Ray/...) what about the winrate of the position. At least, one can quickly compare different variations outcomes.

But not the complete variations and data. At the moment, my code is just too messy for that (and it's so embarrassing to thinking about all those people looking at in on github :oops: ). But it would be a cool feature yes, so maybe in the future.

Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer

Posted: Fri Jan 26, 2018 1:40 pm
by johnsmith
pnprog wrote:I am planning to add a small analysis feature in the "Open position" windows, but only something simple to ask Leela (or AQ/Ray/...) what about the winrate of the position. At least, one can quickly compare different variations outcomes.
Of course. It is just to have a simple comparison in this window ;)
pnprog wrote:and it's so embarrassing to thinking about all those people looking at in on github :oops: ).
I wouldn't say that :) Plus you're the first and the only to implement these ideas!

And yes, I'm already using LZ as new networks are getting stronger rapidly.

Re: Announcing GoReviewPartner - v0.10 (supporting Leela Zer

Posted: Mon Jan 29, 2018 10:03 am
by pleiade67
Hello,

Mac OSX 10.12 here. I tested successfully GRP V0.10 with the following engines:
- leela 0.11
- leela-zero 0.11
- gnugo 3.8

As expected it was unfortunately not possible to build Ray and AQ on Mac OS.

Leela and gnugo already fully meet my needs :) . Thanks again ! :clap:

(note: for the engines which are not used, it is necessary to fill in the command line in the engine settings to gain access to the sgf analysis. Any directory path should make it.)