Page 3 of 6
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 8:26 am
by fwiffo
If everyone is happy with how EidoGo is working at this point and no major problems have presented themselves, would anyone have a problem if I moved it to the "sgf" tag (and sgf-full and sgf-problem) at this point?
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 9:32 am
by apetresc
fwiffo wrote:If everyone is happy with how EidoGo is working at this point and no major problems have presented themselves, would anyone have a problem if I moved it to the "sgf" tag (and sgf-full and sgf-problem) at this point?
I vote for doing this. The sooner we make it the de-facto standard, the fewer stale Flash applets we'll have hanging around for perpetuity.
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 9:39 am
by Tryphon
I vote for that too.
Is there a simple way to navigate between variations with Eidogo (using keyboard) ?
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 12:26 pm
by Jordus
Eidogo can bow be used with sgf tags.
Eidogo-full and eidogo-problem are still the same. Should they be switched to sgf-full sgf-problem or is this ok?
FlashGoban is still available using goban tags.
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 12:38 pm
by fwiffo
Yeah, I think they should be the same for consistency (I went ahead and changed them).
@Tryphon: You can navigate EidoGo with the arrow keys (assuming it has focus). Left and Right go backward and forward as expected. Up and Down go to the beginning and end respectively.
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 1:12 pm
by Tryphon
No key for going from a node to another in the variation tree ? (like up and down in the KGS client)
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 1:27 pm
by fwiffo
There isn't an exact analog to that, but you can press the appropriate alphanumeric that corresponds to the label on the board or its variation number (which should also display on the board). E.g. if you hit 2ddb11 on eidogo.com you'll find yourself navigating the avalanche joseki.
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 2:03 pm
by Bill Spight
I voted for Flash Goban. Not because It is any great shakes, but because Eidogo seems to suck.
For instance, I am now unable to play the variations in the SGF file I posted on the Boundary play mathematics thread. In addition, it does not seem possible for a reader of the note to download or otherwise access the file. Also, it is possible to pass, and perhaps otherwise make plays, which leaves the display in a state from which it seems impossible to return to the original condition easily.
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 2:08 pm
by Jordus
Bill Spight wrote:I voted for Flash Goban. Not because It is any great shakes, but because Eidogo seems to suck.
For instance, I am now unable to play the variations in the SGF file I posted on the Boundary play mathematics thread. In addition, it does not seem possible for a reader of the note to download or otherwise access the file. Also, it is possible to pass, and perhaps otherwise make plays, which leaves the display in a state from which it seems impossible to return to the original condition easily.
flash is still available using
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 2:17 pm
by pasky
Wouldn't it make more sense for the reader to choose a display of preference, instead of the poster?
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 2:18 pm
by Jordus
pasky wrote:Wouldn't it make more sense for the reader to choose a display of preference, instead of the poster?
another possible feature to look into....
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 2:24 pm
by fwiffo
Yeah, you can still use the flash one if you want, but I'd like to fix the EidoGo problems you're having.
I don't know why the variations don't appear on the board for that particular file. They're supposed to, and they usually do; I suspect EidoGo gets confused because black makes two moves in a row in one of the variations. White obviously plays tenuki, but I've usually seen that indicated in an SGF file with a pass. I'll see if I can fix EidoGo to show those variations properly (probably won't get to look at that until at least the weekend). However, in the mean time you can use the "sgf-full" tag which includes a variation tree through which you can navigate to the other variation.
As far as downloading the file, there is a button at the bottom of the player to download the SGF file, and it worked fine for me in that thread. Does that not work for you? It may be a browser compatibility issue - what web browser are you using?
As for the issue with making a play or passing - they can just step back a move to get back to where they were... Are you looking for some sort of revert feature to restore the variation tree to its original state? That's probably possible; I'll look into adding it. In the mean time, they can click refresh in their browser.
----
The problem with letting the reader choose which they prefer is that it would be extremely complicated to set up. We probably wouldn't be able to use bbcodes anymore, which means we'd probably have to modify the phpbb codebase, which would be a maintenance problem.
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 2:44 pm
by Kirby
fwiffo wrote:The problem with letting the reader choose which they prefer is that it would be extremely complicated to set up. We probably wouldn't be able to use bbcodes anymore, which means we'd probably have to modify the phpbb codebase, which would be a maintenance problem.
One way might be to put both eidogo and the flash viewer on the page, but make say the flash one hidden. Then put a button to toggle visibility between the two. I dunno if it's a desired feature, though.
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 3:18 pm
by Bill Spight
fwiffo wrote:Yeah, you can still use the flash one if you want, but I'd like to fix the EidoGo problems you're having.
Bueno!
I don't know why the variations don't appear on the board for that particular file. They're supposed to, and they usually do; I suspect EidoGo gets confused because black makes two moves in a row in one of the variations. White obviously plays tenuki, but I've usually seen that indicated in an SGF file with a pass. I'll see if I can fix EidoGo to show those variations properly (probably won't get to look at that until at least the weekend). However, in the mean time you can use the "sgf-full" tag which includes a variation tree through which you can navigate to the other variation.
Variation trees sound nice.
As for evaluation files, which I often post, you want to have either player move first in a variation. (That is also useful in ordinary comments, when you want to show a threat or aji.
)
As far as downloading the file, there is a button at the bottom of the player to download the SGF file, and it worked fine for me in that thread. Does that not work for you? It may be a browser compatibility issue - what web browser are you using?
It doesn't show up. I am using Safari.
BTW, the color contrast on the EIdogo display is not very good. It makes a lot of the text hard to read. Even the board coordinates.
As for the issue with making a play or passing - they can just step back a move to get back to where they were...
Not in my experience. For instance, if I am looking at the board and happen to press the pass button, I can no longer play the original game. Pressing play just makes a pass.
Are you looking for some sort of revert feature to restore the variation tree to its original state? That's probably possible; I'll look into adding it. In the mean time, they can click refresh in their browser.
Well, if you are simply viewing a file, why have the functionality to make plays, and so on? However, if you can, say, add a variation or make a comment, and then copy the new file and use it in a reply, that would be very nice.
Re: SGF VIEWER FLASHGOBAN Or EIDOGO
Posted: Thu Apr 22, 2010 6:43 pm
by fwiffo
If you'd like to use the one with the variation tree, just use [sgf-full] instead of [sgf]. It's possible I messed up a configuration option that's causing the problems you experienced with variations (there's a few other things that are acting not as expected, so I will look into that more). If not, then it's a bug and I will try to fix it when I have time to dig into the EidoGo code. Either way, when I fix that, it should also get around the issue you're having where you can't get back to the main variation after playing a different move (though again, in the mean time, using [sgf-full] will let you do so by navigating the variation tree).
I will try to get the download button working in Safari. I knew that it didn't work in some older browsers like IE6, but I'm surprised it's not working for Safari users. It may work if you embed the SGF by url instead of inline. But I'll try to get it working both ways, though it may require some work. I plan to get a "copy to clipboard" option working too, which is one of the reasons why I left some of the edit controls turned on. EidoGo has some hooks in it for exporting both SGF and Sensei's-style diagrams in different ways. So theoretically, at some point, someone could post a game for review, you could add variations and comments in-browser, and then post the resulting sgf immediately without having to use an external SGF editor at all.
Making an alternate color scheme for EidoGo isn't too hard, I'll try to make something that's higher-contrast. I'd really actually like to have a custom theme for the forum and theme EidoGo to match color-wise. It's also possible to make the theme have larger stones if people don't like the current size.