Life In 19x19

Click Here To Show Diagram Code

[go]$$Wc Thanks Kirby
$$|-------------------
$$|. . . . . . . . . . |
$$|. . . . . . . . . . |
$$|-------------------[/go]

• It's bad style from a web standards perspective, because it ignores user settings for fonts, so you're breaking accessibility.
• It doesn't get indexed by search engines, nor by the forum search function, so it makes it harder to find things.
• You can't format it with the forum tools, so no italic, bold, or things like @ (very useful in captions)

HermanHiddema wrote:I really dislike having the caption text be part of the image.

• It's bad style from a web standards perspective, because it ignores user settings for fonts, so you're breaking accessibility.
• It doesn't get indexed by search engines, nor by the forum search function, so it makes it harder to find things.
• You can't format it with the forum tools, so no italic, bold, or things like @ (very useful in captions)

It would be much better, IMO, to put a div tag around the image, set to slightly more than the width of the image for text wrapping purposes, and have the text inside that div, under the image, as normal text.

HermanHiddema wrote:It would be much better, IMO, to put a div tag around the image, set to slightly more than the width of the image for text wrapping purposes, and have the text inside that div, under the image, as normal text.

Kirby wrote:So would you like to use any of the forum tags in the caption? If so, do you want the caption input method to remain a part of the diagram code? Right now we use sltxt2png's built in caption parsing, but if we allow for all forum tags, maybe we can do this a different way.

HermanHiddema wrote:

Kirby wrote:So would you like to use any of the forum tags in the caption? If so, do you want the caption input method to remain a part of the diagram code? Right now we use sltxt2png's built in caption parsing, but if we allow for all forum tags, maybe we can do this a different way.

Ideally, the caption would just be passed back to the bbcode interpreter, yes.

Click Here To Show Diagram Code

[go]$$B This is the caption
$$ ------------
$$| . . . 2 . .
$$| . a 1 . b .
$$| . . . . . .[/go]

$$B This is the caption
$$ ------------
$$| . . . 2 . .
$$| . a 1 . b .
$$| . . . . . .

Click Here To Show Diagram Code

[go]$$B This is the caption
$$ ------------
$$| . . . 2 . .
$$| . a 1 . b .
$$| . . . . . .[/go]

[go]{TEXT}[/go]

<pre style="display: none;" class="go-diagram">{TEXT}</pre><script type="text/javascript">... javscript code ...</script>

fwiffo wrote:The caption has already been passed through the bbcode interpreter by the time it gets to your javascript...

...

fwiffo wrote:No, I'm saying the bbcode parser has already parsed any tags inside diagram code before you even get to do anything with it, and it does it in one pass.

For example, imagine we had a simpler bbcode rule that replaces:

Code: Select all

[go]{TEXT}[/go]

with:

Code: Select all

<pre class="go-diagram">{TEXT}</pre>

Then the following:

Code: Select all

[go]$$B This is [i]a caption[/i] with [url=http://lifein19x19.com]<this link> & [b]bold text[/b][/url]
$$  ----------------------
$$ | . . . . . . . . . . .
$$ | . . . . . . . . . . .
$$ | . . . 5 3 4 . . . 8 .
$$ | . . 1 , 2 6 . . . . .
$$ | . . . . . . . . . . .
$$ | . . 7 . . . . . . . .
$$ | . . . . . . . . . . .[/go]

gets replaced with:

Code: Select all

<pre class="go-diagram">$$B This is <em>a caption</em> with <a href="http://lifein19x19.com">&lt;this link&gt;</a><br /> &amp; <strong>bold text</strong>
$$  ----------------------<br />
$$ | . . . . . . . . . . .<br />
$$ | . . . . . . . . . . .<br />
$$ | . . . 5 3 4 . . . 8 .<br />
$$ | . . 1 , 2 6 . . . . .<br />
$$ | . . . . . . . . . . .<br />
$$ | . . 7 . . . . . . . .<br />
$$ | . . . . . . . . . . .</pre>

or something similar (I'm pretty sure it removes the newlines, but I left them in for readability). You can see it replaced the bbcodes inside your [go] bbcode with the equivalent HTML and escaped special HTML characters like <, > and &. Smilies would also be converted to the appropriate <img> tags.

Your funkytag example would not do anything weird, because it's only a single pass. so [go1] would get converted to [funkytag] but that would be it, and viewers would just see [funkytag]. It wouldn't go into an infinite loop or anything.

My explanation may have been confusing, cause if you click on the "show diagram code" for the first example you'd see the word "caption" in italics because the [i] bbcode I put in there got converted to an <em> (as you can see in the diagram itself). So "show diagram code" is lying because it doesn't unconvert the bbcodes or anything. That's a much hairier problem. I don't know if bbcodes have a mechanism to allow certain text inside your tag to go through unmolested. My guess is that it does not because it would be really easy to create HTML injection vulnerabilities.