Page 1 of 2
Default to sgf-full
Posted: Thu Sep 15, 2011 5:36 am
by HermanHiddema
Can we make it so that the sgf tags do the same thing that the sgf-full tags do, and add sgf-small tags for when people want the smaller version?
I'm sure the smaller version is useful on narrow blogs and such, but on L19, I see no benefits. It just removes useful features in exchange for empty space on the right of the diagram, and it is downright annoying on smaller screens (on my 1024x600 notebook, I cannot fit both the board and the comments on screen).
Re: Default to sgf-full
Posted: Thu Sep 15, 2011 11:19 am
by jts
I like this, but I imagine there's a backwards-compatibility problem.
I guess it's not too bad - people who have posted sgf-small in the past probably won't be too angry if they suddenly all become sgf-full.
But if that worries people, we could just change what the buttons say. (I.e., the "sgf" button would create an "sgf-full" tag.)
Re: Default to sgf-full
Posted: Wed Sep 21, 2011 2:38 am
by HermanHiddema
Bump!
This shouldn't be too hard, should it?
Re: Default to sgf-full
Posted: Wed Sep 21, 2011 4:03 am
by Kirby
Sorry for the delay, I just noticed this thread.
I swapped sgf and sgf-full, and renamed sgf-full to sgf-small, as per your request. To avoid any potential compatibility issues, sgf-full still exists, but is not displayed on the posting page.
sgf:
(;GM[1]FF[3]SZ[19]AB[sp][rp][qp][pq][oq][nq]AW[rs][rr][rq][sq][pr]PL[B];B[ps];W[or];B[nr];W[os];B[qr])
sgf-small:
(;GM[1]FF[3]SZ[19]AB[sp][rp][qp][pq][oq][nq]AW[rs][rr][rq][sq][pr]PL[B];B[ps];W[or];B[nr];W[os];B[qr])
sgf-full:
(;GM[1]FF[3]SZ[19]AB[sp][rp][qp][pq][oq][nq]AW[rs][rr][rq][sq][pr]PL[B];B[ps];W[or];B[nr];W[os];B[qr])
Re: Default to sgf-full
Posted: Wed Sep 21, 2011 4:05 am
by HermanHiddema
Thanks!

Re: Default to sgf-full
Posted: Wed Sep 21, 2011 5:00 am
by gaius
A lot of SGF's around the forum are now not showing up for me at all (for example
viewtopic.php?p=78314#p78314). Is this related?
Re: Default to sgf-full
Posted: Wed Sep 21, 2011 5:02 am
by Li Kao
Looks like [ sgf-full ] doesn't work anymore.
Re: Default to sgf-full
Posted: Wed Sep 21, 2011 5:31 am
by Jordus
The code just needs reparsed now. Basically the mods have to just resubmit the post through the parser. I am going through the L19 Tourney thread right now. If you see any sgfs anywhere that aren't parsed just report the post or post the thread link here so we can take care of it.
If the post is your own you can fix it yourself. To do follow these steps.
1. Edit your post.
2. delete the first sgf tag or bracket.
3. submit your post.
4. edit your post again.
5. replace the delete sgf tag or bracket.
6. submit post.
The code is now reparsed and the sgf showing correctly.
Re: Default to sgf-full
Posted: Wed Sep 21, 2011 10:16 am
by xed_over
Jordus wrote:The code just needs reparsed now.
don't you just need to run a simple backend datafix script?
Re: Default to sgf-full
Posted: Wed Sep 21, 2011 6:29 pm
by Kirby
Sorry, all. I didn't realize this implication when I made the change. I suppose I should only make changes if I am going to stick around for more than a couple of minutes to see if they actually worked.

It looks like there is a reparse mod that could work, anyway:
http://phpbbmodders.net/board/viewtopic.php?t=2875However, for now, I'll let one of the other admins try this out, as I feel I've already done enough damage...

Re: Default to sgf-full
Posted: Wed Sep 21, 2011 7:24 pm
by Jordus
Would be great if the download link wasn't broken.
Re: Default to sgf-full
Posted: Wed Sep 21, 2011 7:29 pm
by Kirby
Jordus wrote:Would be great if the download link wasn't broken.
Hmm, seems you can use Support Toolkit (
http://www.phpbb.com/support/stk/), possibly. I haven't looked into it much, though.
Re: Default to sgf-full
Posted: Wed Sep 21, 2011 10:02 pm
by Jordus
OK! Got the STK installed and ran it. It looked like it got through it all. Everything should be a-ok now but if you see any sgfs displayed as just text just report the message.
Re: Default to sgf-full
Posted: Wed Sep 21, 2011 10:23 pm
by ez4u
It appears there are still some
here and
there.
Re: Default to sgf-full
Posted: Wed Sep 21, 2011 11:53 pm
by Jordus
ez4u wrote:It appears there are still some
here and
there.
Should be taken care of.