It is currently Wed Apr 30, 2025 4:11 pm

All times are UTC - 8 hours [ DST ]




Post new topic Reply to topic  [ 16 posts ] 
Author Message
Offline
 Post subject: Default to sgf-full
Post #1 Posted: Thu Sep 15, 2011 5:36 am 
Gosei
User avatar

Posts: 2011
Location: Groningen, NL
Liked others: 202
Was liked: 1087
Rank: Dutch 4D
GD Posts: 645
Universal go server handle: herminator
Can we make it so that the sgf tags do the same thing that the sgf-full tags do, and add sgf-small tags for when people want the smaller version?

I'm sure the smaller version is useful on narrow blogs and such, but on L19, I see no benefits. It just removes useful features in exchange for empty space on the right of the diagram, and it is downright annoying on smaller screens (on my 1024x600 notebook, I cannot fit both the board and the comments on screen).


This post by HermanHiddema was liked by 8 people: dfan, ez4u, Joaz Banbeck, jts, Li Kao, mic, Suji, Toge
Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #2 Posted: Thu Sep 15, 2011 11:19 am 
Oza
User avatar

Posts: 2659
Liked others: 310
Was liked: 631
Rank: kgs 6k
I like this, but I imagine there's a backwards-compatibility problem.

I guess it's not too bad - people who have posted sgf-small in the past probably won't be too angry if they suddenly all become sgf-full.

But if that worries people, we could just change what the buttons say. (I.e., the "sgf" button would create an "sgf-full" tag.)

Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #3 Posted: Wed Sep 21, 2011 2:38 am 
Gosei
User avatar

Posts: 2011
Location: Groningen, NL
Liked others: 202
Was liked: 1087
Rank: Dutch 4D
GD Posts: 645
Universal go server handle: herminator
Bump!

This shouldn't be too hard, should it?

Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #4 Posted: Wed Sep 21, 2011 4:03 am 
Honinbo

Posts: 9552
Liked others: 1602
Was liked: 1712
KGS: Kirby
Tygem: 커비라고해
Sorry for the delay, I just noticed this thread.

I swapped sgf and sgf-full, and renamed sgf-full to sgf-small, as per your request. To avoid any potential compatibility issues, sgf-full still exists, but is not displayed on the posting page.

sgf:


sgf-small:


sgf-full:

_________________
be immersed


This post by Kirby was liked by 2 people: dfan, Li Kao
Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #5 Posted: Wed Sep 21, 2011 4:05 am 
Gosei
User avatar

Posts: 2011
Location: Groningen, NL
Liked others: 202
Was liked: 1087
Rank: Dutch 4D
GD Posts: 645
Universal go server handle: herminator
Thanks! :salute:


This post by HermanHiddema was liked by: Kirby
Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #6 Posted: Wed Sep 21, 2011 5:00 am 
Lives in gote
User avatar

Posts: 476
Liked others: 193
Was liked: 83
Rank: Dutch 2 dan
GD Posts: 56
KGS: hopjesvla
A lot of SGF's around the forum are now not showing up for me at all (for example viewtopic.php?p=78314#p78314). Is this related?

_________________
My name is Gijs, from Utrecht, NL.

When in doubt, play the most aggressive move

Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #7 Posted: Wed Sep 21, 2011 5:02 am 
Lives in gote
User avatar

Posts: 643
Location: Munich, Germany
Liked others: 115
Was liked: 102
Rank: KGS 3k
KGS: LiKao / Loki
Looks like [ sgf-full ] doesn't work anymore.

_________________
Sanity is for the weak.

Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #8 Posted: Wed Sep 21, 2011 5:31 am 
Site Admin
User avatar

Posts: 1125
Location: Allegan, MI, USA
Liked others: 18
Was liked: 121
Rank: KGS 9k
Universal go server handle: Jordus
The code just needs reparsed now. Basically the mods have to just resubmit the post through the parser. I am going through the L19 Tourney thread right now. If you see any sgfs anywhere that aren't parsed just report the post or post the thread link here so we can take care of it.

If the post is your own you can fix it yourself. To do follow these steps.

1. Edit your post.
2. delete the first sgf tag or bracket.
3. submit your post.
4. edit your post again.
5. replace the delete sgf tag or bracket.
6. submit post.

The code is now reparsed and the sgf showing correctly.

_________________
I'm thinking...

Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #9 Posted: Wed Sep 21, 2011 10:16 am 
Oza

Posts: 2264
Liked others: 1180
Was liked: 553
Jordus wrote:
The code just needs reparsed now.

don't you just need to run a simple backend datafix script?


This post by xed_over was liked by: Li Kao
Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #10 Posted: Wed Sep 21, 2011 6:29 pm 
Honinbo

Posts: 9552
Liked others: 1602
Was liked: 1712
KGS: Kirby
Tygem: 커비라고해
Sorry, all. I didn't realize this implication when I made the change. I suppose I should only make changes if I am going to stick around for more than a couple of minutes to see if they actually worked. :-)

It looks like there is a reparse mod that could work, anyway:
http://phpbbmodders.net/board/viewtopic.php?t=2875

However, for now, I'll let one of the other admins try this out, as I feel I've already done enough damage... :-?

_________________
be immersed

Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #11 Posted: Wed Sep 21, 2011 7:24 pm 
Site Admin
User avatar

Posts: 1125
Location: Allegan, MI, USA
Liked others: 18
Was liked: 121
Rank: KGS 9k
Universal go server handle: Jordus
Kirby wrote:
It looks like there is a reparse mod that could work, anyway:
http://phpbbmodders.net/board/viewtopic.php?t=2875


Would be great if the download link wasn't broken.

_________________
I'm thinking...

Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #12 Posted: Wed Sep 21, 2011 7:29 pm 
Honinbo

Posts: 9552
Liked others: 1602
Was liked: 1712
KGS: Kirby
Tygem: 커비라고해
Jordus wrote:
Kirby wrote:
It looks like there is a reparse mod that could work, anyway:
http://phpbbmodders.net/board/viewtopic.php?t=2875


Would be great if the download link wasn't broken.


Hmm, seems you can use Support Toolkit (http://www.phpbb.com/support/stk/), possibly. I haven't looked into it much, though.

_________________
be immersed

Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #13 Posted: Wed Sep 21, 2011 10:02 pm 
Site Admin
User avatar

Posts: 1125
Location: Allegan, MI, USA
Liked others: 18
Was liked: 121
Rank: KGS 9k
Universal go server handle: Jordus
OK! Got the STK installed and ran it. It looked like it got through it all. Everything should be a-ok now but if you see any sgfs displayed as just text just report the message.

_________________
I'm thinking...

Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #14 Posted: Wed Sep 21, 2011 10:23 pm 
Oza
User avatar

Posts: 2414
Location: Tokyo, Japan
Liked others: 2350
Was liked: 1332
Rank: Jp 6 dan
KGS: ez4u
It appears there are still some here and there.

_________________
Dave Sigaty
"Short-lived are both the praiser and the praised, and rememberer and the remembered..."
- Marcus Aurelius; Meditations, VIII 21

Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #15 Posted: Wed Sep 21, 2011 11:53 pm 
Site Admin
User avatar

Posts: 1125
Location: Allegan, MI, USA
Liked others: 18
Was liked: 121
Rank: KGS 9k
Universal go server handle: Jordus
ez4u wrote:
It appears there are still some here and there.


Should be taken care of.

_________________
I'm thinking...


This post by Jordus was liked by: ez4u
Top
 Profile  
 
Offline
 Post subject: Re: Default to sgf-full
Post #16 Posted: Thu Sep 22, 2011 12:39 am 
Oza
User avatar

Posts: 2414
Location: Tokyo, Japan
Liked others: 2350
Was liked: 1332
Rank: Jp 6 dan
KGS: ez4u
I checked some of the older posts in game analysis and did not see any more. Looks good!

_________________
Dave Sigaty
"Short-lived are both the praiser and the praised, and rememberer and the remembered..."
- Marcus Aurelius; Meditations, VIII 21

Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 16 posts ] 

All times are UTC - 8 hours [ DST ]


Who is online

Users browsing this forum: No registered users and 1 guest


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB © 2000, 2002, 2005, 2007 phpBB Group