Scoring estimate question

Comments, questions, rants, etc, that are specifically about KGS go here.
User avatar
Li Kao
Lives in gote
Posts: 643
Joined: Wed Apr 21, 2010 10:37 am
Rank: KGS 3k
GD Posts: 0
KGS: LiKao / Loki
Location: Munich, Germany
Has thanked: 115 times
Been thanked: 102 times

Re: Scoring estimate question

Post by Li Kao »

Why does SE only work with the offline client? Does it contain unverifiable or native code?
Sanity is for the weak.
User avatar
wms
Lives in gote
Posts: 450
Joined: Tue Apr 20, 2010 4:23 pm
GD Posts: 0
KGS: wms
Location: Portland, OR USA
Has thanked: 257 times
Been thanked: 287 times
Contact:

Re: Scoring estimate question

Post by wms »

Originally, the SE was almost as big as the rest of the client put together, so I left it out of the applet to help people with slow internet connections.

But now the client is bigger and very few people are still on dialup, so it makes no sense to leave it out. When I get around to it I should add it to the applet.
Marcus
Gosei
Posts: 1387
Joined: Tue Apr 20, 2010 8:51 am
GD Posts: 209
KGS: Marcus316
Has thanked: 139 times
Been thanked: 111 times

Re: Scoring estimate question

Post by Marcus »

wms wrote:Yeah, the score estimator was written by a Mr. Yoshikawa. He was a friend of Richard Bozulich's. I met him in Japan and he offered his board evaluation code to KGS, I built the estimator out of it from that.

I do not know how the algorithm works. Several people have looked at the code (I give it away when Mr. Yoshikawa gives me permission to). They all wanted to make small, simple changes (work with non-19x19 boards, let the player say that a group is alive or dead, etc.)...they all ran away screaming when they saw the code. It is very, uhhh, peculiarly, written. :o


This makes me VERY curious. Any chance you could get permission to pass along the code to me? I don't need it or anything, I just want to look at the code. Anything that resists refactoring like that MUST me interesting. :D
User avatar
wms
Lives in gote
Posts: 450
Joined: Tue Apr 20, 2010 4:23 pm
GD Posts: 0
KGS: wms
Location: Portland, OR USA
Has thanked: 257 times
Been thanked: 287 times
Contact:

Re: Scoring estimate question

Post by wms »

Marcus wrote:This makes me VERY curious. Any chance you could get permission to pass along the code to me? I don't need it or anything, I just want to look at the code. Anything that resists refactoring like that MUST me interesting. :D
You'll have to find and ask Yoshikawa yourself.

But here's a hint as to the troubles with it:

* No comments
* Functions thousands of lines long
* All variables (and most functions and even many of the classes) have single-letter names
* Chars used as enums (e.g., code like "if (y < 5) { z = 'j'; }" is all over the place.)

So you've been warned. :twisted:
User avatar
Harleqin
Lives in sente
Posts: 921
Joined: Sat Mar 06, 2010 10:31 am
Rank: German 2 dan
GD Posts: 0
Has thanked: 401 times
Been thanked: 164 times

Re: Scoring estimate question

Post by Harleqin »

Heh, me too :).
A good system naturally covers all corner cases without further effort.
User avatar
palapiku
Lives in sente
Posts: 761
Joined: Sun Apr 25, 2010 11:25 pm
Rank: the k-word
GD Posts: 0
Has thanked: 152 times
Been thanked: 204 times

Re: Scoring estimate question

Post by palapiku »

wms wrote:
Marcus wrote:This makes me VERY curious. Any chance you could get permission to pass along the code to me? I don't need it or anything, I just want to look at the code. Anything that resists refactoring like that MUST me interesting. :D
You'll have to find and ask Yoshikawa yourself.

But here's a hint as to the troubles with it:

* No comments
* Functions thousands of lines long
* All variables (and most functions and even many of the classes) have single-letter names
* Chars used as enums (e.g., code like "if (y < 5) { z = 'j'; }" is all over the place.)

So you've been warned. :twisted:

This would have been impressive had the code actually worked well.
Marcus
Gosei
Posts: 1387
Joined: Tue Apr 20, 2010 8:51 am
GD Posts: 209
KGS: Marcus316
Has thanked: 139 times
Been thanked: 111 times

Re: Scoring estimate question

Post by Marcus »

wms wrote:
Marcus wrote:This makes me VERY curious. Any chance you could get permission to pass along the code to me? I don't need it or anything, I just want to look at the code. Anything that resists refactoring like that MUST me interesting. :D
You'll have to find and ask Yoshikawa yourself.

But here's a hint as to the troubles with it:

* No comments
* Functions thousands of lines long
* All variables (and most functions and even many of the classes) have single-letter names
* Chars used as enums (e.g., code like "if (y < 5) { z = 'j'; }" is all over the place.)

So you've been warned. :twisted:


Ouch ... still that's not as bad as I've seen (really!).
User avatar
ketchup
Lives with ko
Posts: 263
Joined: Sat Apr 24, 2010 2:48 pm
Rank: Eternal 10k
GD Posts: 188
Has thanked: 127 times
Been thanked: 18 times

Re: Scoring estimate question

Post by ketchup »

The correct answer is that it accounts for black living via ko threat.
I know nothing.
Post Reply