I think you might have caught things when I was experimenting with Herman's suggestion. I removed the float left that was requested. Does it look alright now (minus the fact that the box is too wide)? I may do some more experimenting in the near future.Redundant wrote:This update really messes with the formatting of the malkovich games. For example, look at big brother 3.
Diagram Captions Should Be Fixed
-
Kirby
- Honinbo
- Posts: 9553
- Joined: Wed Feb 24, 2010 6:04 pm
- GD Posts: 0
- KGS: Kirby
- Tygem: 커비라고해
- Has thanked: 1583 times
- Been thanked: 1707 times
Re: Diagram Captions Should Be Fixed
be immersed
- Redundant
- Lives in sente
- Posts: 924
- Joined: Thu Apr 22, 2010 3:00 pm
- Rank: lazy
- GD Posts: 0
- KGS: redundant/silchas
- Tygem: redundant
- Wbaduk: redundant
- DGS: redundant
- OGS: redundant
- Location: Pittsburgh
- Has thanked: 45 times
- Been thanked: 103 times
Re: Diagram Captions Should Be Fixed
It's fixed.Kirby wrote:I think you might have caught things when I was experimenting with Herman's suggestion. I removed the float left that was requested. Does it look alright now (minus the fact that the box is too wide)? I may do some more experimenting in the near future.Redundant wrote:This update really messes with the formatting of the malkovich games. For example, look at big brother 3.
-
Kirby
- Honinbo
- Posts: 9553
- Joined: Wed Feb 24, 2010 6:04 pm
- GD Posts: 0
- KGS: Kirby
- Tygem: 커비라고해
- Has thanked: 1583 times
- Been thanked: 1707 times
Re: Diagram Captions Should Be Fixed
I have tried doing all of the things that you mentioned, but setting the box to left float seems to hurt the layout when there are multiple diagrams in a single post. For now, I am using align-block, with an added modification so that it shows up in IE.HermanHiddema wrote:Wonderful, thanks!Kirby wrote:Okay, there you go:
I made the text bold by default, because it doesn't seem to look that nice otherwise. Let me know if you want this updated, or anything else.
Personally, I would prefer if diagrams were put inside a box, with the caption inside it and a (faint) line around it. Not bold by default would then allow the use of bold for emphasis.
If that box would also float to the left, allowing the text to flow around it, that would be great. The current implementation results in a lot of white space next to diagrams, and thus makes posts longer than they need to be, IMO.
Anyway, this is already a huge improvement!
The box seems to wrap around the image and caption, now, but as you can see, the text is not to the right of the image this way, as you desire.
If you have any suggestions regarding the left float situation, please feel free to let me know. Until I solve that issue, I'll take the other suggestions you had (box around image and text, and not bolding the text).
be immersed
- daniel_the_smith
- Gosei
- Posts: 2116
- Joined: Wed Apr 21, 2010 8:51 am
- Rank: 2d AGA
- GD Posts: 1193
- KGS: lavalamp
- Tygem: imapenguin
- IGS: lavalamp
- OGS: daniel_the_smith
- Location: Silicon Valley
- Has thanked: 152 times
- Been thanked: 330 times
- Contact:
Re: Diagram Captions Should Be Fixed
They look great! Thanks!
That which can be destroyed by the truth should be.
--
My (sadly neglected, but not forgotten) project: http://dailyjoseki.com
--
My (sadly neglected, but not forgotten) project: http://dailyjoseki.com
- Joaz Banbeck
- Judan
- Posts: 5546
- Joined: Sun Dec 06, 2009 11:30 am
- Rank: 1D AGA
- GD Posts: 1512
- Kaya handle: Test
- Location: Banbeck Vale
- Has thanked: 1080 times
- Been thanked: 1434 times
Re: Diagram Captions Should Be Fixed
Thank you, Kirby!

Help make L19 more organized. Make an index: https://lifein19x19.com/viewtopic.php?f=14&t=5207
- HermanHiddema
- Gosei
- Posts: 2011
- Joined: Tue Apr 20, 2010 10:08 am
- Rank: Dutch 4D
- GD Posts: 645
- Universal go server handle: herminator
- Location: Groningen, NL
- Has thanked: 202 times
- Been thanked: 1086 times
Re: Diagram Captions Should Be Fixed
Thanks again, this looks great!Kirby wrote:I have tried doing all of the things that you mentioned, but setting the box to left float seems to hurt the layout when there are multiple diagrams in a single post. For now, I am using align-block, with an added modification so that it shows up in IE.HermanHiddema wrote:Wonderful, thanks!Kirby wrote:Okay, there you go:
I made the text bold by default, because it doesn't seem to look that nice otherwise. Let me know if you want this updated, or anything else.
Personally, I would prefer if diagrams were put inside a box, with the caption inside it and a (faint) line around it. Not bold by default would then allow the use of bold for emphasis.
If that box would also float to the left, allowing the text to flow around it, that would be great. The current implementation results in a lot of white space next to diagrams, and thus makes posts longer than they need to be, IMO.
Anyway, this is already a huge improvement!
The box seems to wrap around the image and caption, now, but as you can see, the text is not to the right of the image this way, as you desire.
If you have any suggestions regarding the left float situation, please feel free to let me know. Until I solve that issue, I'll take the other suggestions you had (box around image and text, and not bolding the text).
Some suggestions on fixing the float issue:
just before the div with the diagram, put <div style="clear:both"></div>. That should make sure that diagrams do not end up next to each other, and that text that comes after a diagram can end up next to it, but never before it.
I would then also suggest putting the "Show diagram code" text inside the diagram div, so it doesn't end up next to it. I'll try playing around locally with the css later this week, to see what I can come up with.
I think it would also be a good idea to add a little padding (say 5px) to the diagram box.