Default to sgf-full

Is something wrong? Do you have any suggestions? Let us know.
User avatar
HermanHiddema
Gosei
Posts: 2011
Joined: Tue Apr 20, 2010 10:08 am
Rank: Dutch 4D
GD Posts: 645
Universal go server handle: herminator
Location: Groningen, NL
Has thanked: 202 times
Been thanked: 1086 times

Default to sgf-full

Post by HermanHiddema »

Can we make it so that the sgf tags do the same thing that the sgf-full tags do, and add sgf-small tags for when people want the smaller version?

I'm sure the smaller version is useful on narrow blogs and such, but on L19, I see no benefits. It just removes useful features in exchange for empty space on the right of the diagram, and it is downright annoying on smaller screens (on my 1024x600 notebook, I cannot fit both the board and the comments on screen).
User avatar
jts
Oza
Posts: 2662
Joined: Sat Sep 18, 2010 4:17 pm
Rank: kgs 6k
GD Posts: 0
Has thanked: 310 times
Been thanked: 632 times

Re: Default to sgf-full

Post by jts »

I like this, but I imagine there's a backwards-compatibility problem.

I guess it's not too bad - people who have posted sgf-small in the past probably won't be too angry if they suddenly all become sgf-full.

But if that worries people, we could just change what the buttons say. (I.e., the "sgf" button would create an "sgf-full" tag.)
User avatar
HermanHiddema
Gosei
Posts: 2011
Joined: Tue Apr 20, 2010 10:08 am
Rank: Dutch 4D
GD Posts: 645
Universal go server handle: herminator
Location: Groningen, NL
Has thanked: 202 times
Been thanked: 1086 times

Re: Default to sgf-full

Post by HermanHiddema »

Bump!

This shouldn't be too hard, should it?
Kirby
Honinbo
Posts: 9553
Joined: Wed Feb 24, 2010 6:04 pm
GD Posts: 0
KGS: Kirby
Tygem: 커비라고해
Has thanked: 1583 times
Been thanked: 1707 times

Re: Default to sgf-full

Post by Kirby »

Sorry for the delay, I just noticed this thread.

I swapped sgf and sgf-full, and renamed sgf-full to sgf-small, as per your request. To avoid any potential compatibility issues, sgf-full still exists, but is not displayed on the posting page.

sgf:


sgf-small:


sgf-full:
be immersed
User avatar
HermanHiddema
Gosei
Posts: 2011
Joined: Tue Apr 20, 2010 10:08 am
Rank: Dutch 4D
GD Posts: 645
Universal go server handle: herminator
Location: Groningen, NL
Has thanked: 202 times
Been thanked: 1086 times

Re: Default to sgf-full

Post by HermanHiddema »

Thanks! :salute:
User avatar
gaius
Lives in gote
Posts: 476
Joined: Tue Apr 27, 2010 2:55 am
Rank: Dutch 2 dan
GD Posts: 56
KGS: hopjesvla
Has thanked: 193 times
Been thanked: 83 times

Re: Default to sgf-full

Post by gaius »

A lot of SGF's around the forum are now not showing up for me at all (for example viewtopic.php?p=78314#p78314). Is this related?
My name is Gijs, from Utrecht, NL.

When in doubt, play the most aggressive move
User avatar
Li Kao
Lives in gote
Posts: 643
Joined: Wed Apr 21, 2010 10:37 am
Rank: KGS 3k
GD Posts: 0
KGS: LiKao / Loki
Location: Munich, Germany
Has thanked: 115 times
Been thanked: 102 times

Re: Default to sgf-full

Post by Li Kao »

Looks like [ sgf-full ] doesn't work anymore.
Sanity is for the weak.
User avatar
Jordus
Site Admin
Posts: 1125
Joined: Fri Dec 04, 2009 6:06 pm
Rank: KGS 9k
GD Posts: 0
Universal go server handle: Jordus
Location: Allegan, MI, USA
Has thanked: 16 times
Been thanked: 116 times
Contact:

Re: Default to sgf-full

Post by Jordus »

The code just needs reparsed now. Basically the mods have to just resubmit the post through the parser. I am going through the L19 Tourney thread right now. If you see any sgfs anywhere that aren't parsed just report the post or post the thread link here so we can take care of it.

If the post is your own you can fix it yourself. To do follow these steps.

1. Edit your post.
2. delete the first sgf tag or bracket.
3. submit your post.
4. edit your post again.
5. replace the delete sgf tag or bracket.
6. submit post.

The code is now reparsed and the sgf showing correctly.
I'm thinking...
xed_over
Oza
Posts: 2264
Joined: Mon Apr 19, 2010 11:51 am
Has thanked: 1179 times
Been thanked: 553 times

Re: Default to sgf-full

Post by xed_over »

Jordus wrote:The code just needs reparsed now.

don't you just need to run a simple backend datafix script?
Kirby
Honinbo
Posts: 9553
Joined: Wed Feb 24, 2010 6:04 pm
GD Posts: 0
KGS: Kirby
Tygem: 커비라고해
Has thanked: 1583 times
Been thanked: 1707 times

Re: Default to sgf-full

Post by Kirby »

Sorry, all. I didn't realize this implication when I made the change. I suppose I should only make changes if I am going to stick around for more than a couple of minutes to see if they actually worked. :-)

It looks like there is a reparse mod that could work, anyway:
http://phpbbmodders.net/board/viewtopic.php?t=2875

However, for now, I'll let one of the other admins try this out, as I feel I've already done enough damage... :-?
be immersed
User avatar
Jordus
Site Admin
Posts: 1125
Joined: Fri Dec 04, 2009 6:06 pm
Rank: KGS 9k
GD Posts: 0
Universal go server handle: Jordus
Location: Allegan, MI, USA
Has thanked: 16 times
Been thanked: 116 times
Contact:

Re: Default to sgf-full

Post by Jordus »

Kirby wrote:It looks like there is a reparse mod that could work, anyway:
http://phpbbmodders.net/board/viewtopic.php?t=2875


Would be great if the download link wasn't broken.
I'm thinking...
Kirby
Honinbo
Posts: 9553
Joined: Wed Feb 24, 2010 6:04 pm
GD Posts: 0
KGS: Kirby
Tygem: 커비라고해
Has thanked: 1583 times
Been thanked: 1707 times

Re: Default to sgf-full

Post by Kirby »

Jordus wrote:
Kirby wrote:It looks like there is a reparse mod that could work, anyway:
http://phpbbmodders.net/board/viewtopic.php?t=2875


Would be great if the download link wasn't broken.


Hmm, seems you can use Support Toolkit (http://www.phpbb.com/support/stk/), possibly. I haven't looked into it much, though.
be immersed
User avatar
Jordus
Site Admin
Posts: 1125
Joined: Fri Dec 04, 2009 6:06 pm
Rank: KGS 9k
GD Posts: 0
Universal go server handle: Jordus
Location: Allegan, MI, USA
Has thanked: 16 times
Been thanked: 116 times
Contact:

Re: Default to sgf-full

Post by Jordus »

OK! Got the STK installed and ran it. It looked like it got through it all. Everything should be a-ok now but if you see any sgfs displayed as just text just report the message.
I'm thinking...
User avatar
ez4u
Oza
Posts: 2414
Joined: Wed Feb 23, 2011 10:15 pm
Rank: Jp 6 dan
GD Posts: 0
KGS: ez4u
Location: Tokyo, Japan
Has thanked: 2351 times
Been thanked: 1332 times

Re: Default to sgf-full

Post by ez4u »

It appears there are still some here and there.
Dave Sigaty
"Short-lived are both the praiser and the praised, and rememberer and the remembered..."
- Marcus Aurelius; Meditations, VIII 21
User avatar
Jordus
Site Admin
Posts: 1125
Joined: Fri Dec 04, 2009 6:06 pm
Rank: KGS 9k
GD Posts: 0
Universal go server handle: Jordus
Location: Allegan, MI, USA
Has thanked: 16 times
Been thanked: 116 times
Contact:

Re: Default to sgf-full

Post by Jordus »

ez4u wrote:It appears there are still some here and there.


Should be taken care of.
I'm thinking...
Post Reply